From 8c16baa51beb50e091f6652c47fc1c8501b93611 Mon Sep 17 00:00:00 2001 From: Yang Li Date: Wed, 16 Feb 2022 09:45:07 +0800 Subject: [PATCH] net: Fix an ignored error return from dm9051_get_regs() The return from the call to dm9051_get_regs() is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'ret', so making 'ret' an int. Eliminate the following coccicheck warning: ./drivers/net/ethernet/davicom/dm9051.c:527:5-8: WARNING: Unsigned expression compared with zero: ret < 0 Reported-by: Abaci Robot Signed-off-by: Yang Li Link: https://lore.kernel.org/r/20220216014507.109117-1-yang.lee@linux.alibaba.com Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/davicom/dm9051.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/davicom/dm9051.c b/drivers/net/ethernet/davicom/dm9051.c index 8436afa34620..6a2bcfbfe891 100644 --- a/drivers/net/ethernet/davicom/dm9051.c +++ b/drivers/net/ethernet/davicom/dm9051.c @@ -519,9 +519,9 @@ static int dm9051_map_init(struct spi_device *spi, struct board_info *db) static int dm9051_map_chipid(struct board_info *db) { struct device *dev = &db->spidev->dev; - unsigned int ret; unsigned short wid; u8 buff[6]; + int ret; ret = dm9051_get_regs(db, DM9051_VIDL, buff, sizeof(buff)); if (ret < 0)