greybus: svc: fix an error handling bug in gb_svc_hello()
Cleanup if gb_svc_queue_deferred_request() fails.
Link: https://lore.kernel.org/r/20220202072016.GA6748@kili
Fixes: ee2f2074fd
("greybus: svc: reconfig APBridgeA-Switch link to handle required load")
Cc: stable@vger.kernel.org # 4.9
[johan: fix commit summary prefix and rename label ]
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20220202113347.1288-2-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
7ab004dbcb
commit
5f8583a3b7
|
@ -866,8 +866,14 @@ static int gb_svc_hello(struct gb_operation *op)
|
|||
|
||||
gb_svc_debugfs_init(svc);
|
||||
|
||||
return gb_svc_queue_deferred_request(op);
|
||||
ret = gb_svc_queue_deferred_request(op);
|
||||
if (ret)
|
||||
goto err_remove_debugfs;
|
||||
|
||||
return 0;
|
||||
|
||||
err_remove_debugfs:
|
||||
gb_svc_debugfs_exit(svc);
|
||||
err_unregister_device:
|
||||
gb_svc_watchdog_destroy(svc);
|
||||
device_del(&svc->dev);
|
||||
|
|
Loading…
Reference in New Issue