Revert "btrfs: compression: don't try to compress if we don't have enough pages"
This reverts commitf216562731
. [BUG] It's no longer possible to create compressed inline extent after commitf216562731
("btrfs: compression: don't try to compress if we don't have enough pages"). [CAUSE] For compression code, there are several possible reasons we have a range that needs to be compressed while it's no more than one page. - Compressed inline write The data is always smaller than one sector and the test lacks the condition to properly recognize a non-inline extent. - Compressed subpage write For the incoming subpage compressed write support, we require page alignment of the delalloc range. And for 64K page size, we can compress just one page into smaller sectors. For those reasons, the requirement for the data to be more than one page is not correct, and is already causing regression for compressed inline data writeback. The idea of skipping one page to avoid wasting CPU time could be revisited in the future. [FIX] Fix it by reverting the offending commit. Reported-by: Zygo Blaxell <ce3g8jdj@umail.furryterror.org> Link: https://lore.kernel.org/linux-btrfs/afa2742.c084f5d6.17b6b08dffc@tnonline.net Fixes:f216562731
("btrfs: compression: don't try to compress if we don't have enough pages") CC: stable@vger.kernel.org # 4.4+ Signed-off-by: Qu Wenruo <wqu@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
parent
3f79f6f624
commit
4e9655763b
|
@ -629,7 +629,7 @@ static noinline int compress_file_range(struct async_chunk *async_chunk)
|
||||||
* inode has not been flagged as nocompress. This flag can
|
* inode has not been flagged as nocompress. This flag can
|
||||||
* change at any time if we discover bad compression ratios.
|
* change at any time if we discover bad compression ratios.
|
||||||
*/
|
*/
|
||||||
if (nr_pages > 1 && inode_need_compress(BTRFS_I(inode), start, end)) {
|
if (inode_need_compress(BTRFS_I(inode), start, end)) {
|
||||||
WARN_ON(pages);
|
WARN_ON(pages);
|
||||||
pages = kcalloc(nr_pages, sizeof(struct page *), GFP_NOFS);
|
pages = kcalloc(nr_pages, sizeof(struct page *), GFP_NOFS);
|
||||||
if (!pages) {
|
if (!pages) {
|
||||||
|
|
Loading…
Reference in New Issue