nvme-pci: always return an ERR_PTR from nvme_pci_alloc_dev
[ Upstream commitdc785d69d7
] Don't mix NULL and ERR_PTR returns. Fixes:2e87570be9
("nvme-pci: factor out a nvme_pci_alloc_dev helper") Signed-off-by: Irvin Cote <irvin.cote@insa-lyon.fr> Reviewed-by: Keith Busch <kbusch@kernel.org> Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
1d7bc76b58
commit
4b8ef68e39
|
@ -3117,7 +3117,7 @@ static struct nvme_dev *nvme_pci_alloc_dev(struct pci_dev *pdev,
|
|||
|
||||
dev = kzalloc_node(sizeof(*dev), GFP_KERNEL, node);
|
||||
if (!dev)
|
||||
return NULL;
|
||||
return ERR_PTR(-ENOMEM);
|
||||
INIT_WORK(&dev->ctrl.reset_work, nvme_reset_work);
|
||||
INIT_WORK(&dev->remove_work, nvme_remove_dead_ctrl_work);
|
||||
mutex_init(&dev->shutdown_lock);
|
||||
|
@ -3162,8 +3162,8 @@ static int nvme_probe(struct pci_dev *pdev, const struct pci_device_id *id)
|
|||
int result = -ENOMEM;
|
||||
|
||||
dev = nvme_pci_alloc_dev(pdev, id);
|
||||
if (!dev)
|
||||
return -ENOMEM;
|
||||
if (IS_ERR(dev))
|
||||
return PTR_ERR(dev);
|
||||
|
||||
result = nvme_dev_map(dev);
|
||||
if (result)
|
||||
|
|
Loading…
Reference in New Issue