OrgACRN
/
acrn-kernel
mirror of https://github.com/projectacrn/acrn-kernel.git
1
0
Fork 0
Code Issues Releases Wiki Activity

net/smc: fix application data exception 

There is a certain probability that following
exceptions will occur in the wrk benchmark test:

Running 10s test @ http://11.213.45.6:80
  8 threads and 64 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     3.72ms   13.94ms 245.33ms   94.17%
    Req/Sec     1.96k   713.67     5.41k    75.16%
  155262 requests in 10.10s, 23.10MB read
Non-2xx or 3xx responses: 3

We will find that the error is HTTP 400 error, which is a serious
exception in our test, which means the application data was
corrupted.

Consider the following scenarios:

CPU0                            CPU1

buf_desc->used = 0;
                                cmpxchg(buf_desc->used, 0, 1)
                                deal_with(buf_desc)

memset(buf_desc->cpu_addr,0);

This will cause the data received by a victim connection to be cleared,
thus triggering an HTTP 400 error in the server.

This patch exchange the order between clear used and memset, add
barrier to ensure memory consistency.

Fixes: 1c5526968e ("net/smc: Clear memory when release and reuse buffer")
Signed-off-by: D. Wythe <alibuda@linux.alibaba.com>
Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
D. Wythe 2023-02-16 14:39:05 +08:00 committed by David S. Miller
parent e40b801b36
commit 475f9ff63e
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
net/smc/smc_core.c
View File

@ -1120,8 +1120,9 @@ static void smcr_buf_unuse(struct smc_buf_desc *buf_desc, bool is_rmb,
smc_buf_free(lgr, is_rmb, buf_desc); smc_buf_free(lgr, is_rmb, buf_desc);
} else { } else {
buf_desc->used = 0; /* memzero_explicit provides potential memory barrier semantics */
memset(buf_desc->cpu_addr, 0, buf_desc->len); memzero_explicit(buf_desc->cpu_addr, buf_desc->len);
WRITE_ONCE(buf_desc->used, 0);
} }
} }
@ -1132,19 +1133,17 @@ static void smc_buf_unuse(struct smc_connection *conn,
if (!lgr->is_smcd && conn->sndbuf_desc->is_vm) { if (!lgr->is_smcd && conn->sndbuf_desc->is_vm) {
smcr_buf_unuse(conn->sndbuf_desc, false, lgr); smcr_buf_unuse(conn->sndbuf_desc, false, lgr);
} else { } else {
conn->sndbuf_desc->used = 0; memzero_explicit(conn->sndbuf_desc->cpu_addr, conn->sndbuf_desc->len);
memset(conn->sndbuf_desc->cpu_addr, 0, WRITE_ONCE(conn->sndbuf_desc->used, 0);
conn->sndbuf_desc->len);
} }
} }
if (conn->rmb_desc) { if (conn->rmb_desc) {
if (!lgr->is_smcd) { if (!lgr->is_smcd) {
smcr_buf_unuse(conn->rmb_desc, true, lgr); smcr_buf_unuse(conn->rmb_desc, true, lgr);
} else { } else {
conn->rmb_desc->used = 0; memzero_explicit(conn->rmb_desc->cpu_addr,
memset(conn->rmb_desc->cpu_addr, 0, conn->rmb_desc->len + sizeof(struct smcd_cdc_msg));
conn->rmb_desc->len + WRITE_ONCE(conn->rmb_desc->used, 0);
sizeof(struct smcd_cdc_msg));
} }
} }
} }