OrgACRN
/
acrn-kernel
mirror of https://github.com/projectacrn/acrn-kernel.git
1
0
Fork 0
Code Issues Releases Wiki Activity

ALSA: pcm: Test for "silence" field in struct "pcm_format_data" 

Syzbot reports "KASAN: null-ptr-deref Write in
snd_pcm_format_set_silence".[1]

It is due to missing validation of the "silence" field of struct
"pcm_format_data" in "pcm_formats" array.

Add a test for valid "pat" and, if it is not so, return -EINVAL.

[1] https://lore.kernel.org/lkml/000000000000d188ef05dc2c7279@google.com/

Reported-and-tested-by: syzbot+205eb15961852c2c5974@syzkaller.appspotmail.com
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20220409012655.9399-1-fmdefrancesco@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Fabio M. De Francesco 2022-04-09 03:26:55 +02:00 committed by Takashi Iwai
parent fee2ec8cce
commit 2f7a26abb8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sound/core/pcm_misc.c
View File

@ -433,7 +433,7 @@ int snd_pcm_format_set_silence(snd_pcm_format_t format, void *data, unsigned int
return 0; return 0;
width = pcm_formats[(INT)format].phys; /* physical width */ width = pcm_formats[(INT)format].phys; /* physical width */
pat = pcm_formats[(INT)format].silence; pat = pcm_formats[(INT)format].silence;
if (! width) if (!width || !pat)
return -EINVAL; return -EINVAL;
/* signed or 1 byte data */ /* signed or 1 byte data */
if (pcm_formats[(INT)format].signd == 1 || width <= 8) { if (pcm_formats[(INT)format].signd == 1 || width <= 8) {