RDMA/rtrs-srv: Do not unconditionally enable irq
[ Upstream commit 3ee7ecd712048ade6482bea4b2f3dcaf039c0348 ]
When IO is completed, rtrs can be called in softirq context,
unconditionally enabling irq could cause panic.
To be on safe side, use spin_lock_irqsave and spin_unlock_irqrestore
instread.
Fixes: 9cb8374804
("RDMA/rtrs: server: main functionality")
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Florian-Ewald Mueller <florian-ewald.mueller@ionos.com>
Signed-off-by: Md Haris Iqbal <haris.iqbal@ionos.com>
Signed-off-by: Grzegorz Prajsner <grzegorz.prajsner@ionos.com>
Link: https://lore.kernel.org/r/20231120154146.920486-2-haris.iqbal@ionos.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
4a8774a633
commit
1e46485045
|
@ -63,8 +63,9 @@ static bool rtrs_srv_change_state(struct rtrs_srv_path *srv_path,
|
|||
{
|
||||
enum rtrs_srv_state old_state;
|
||||
bool changed = false;
|
||||
unsigned long flags;
|
||||
|
||||
spin_lock_irq(&srv_path->state_lock);
|
||||
spin_lock_irqsave(&srv_path->state_lock, flags);
|
||||
old_state = srv_path->state;
|
||||
switch (new_state) {
|
||||
case RTRS_SRV_CONNECTED:
|
||||
|
@ -85,7 +86,7 @@ static bool rtrs_srv_change_state(struct rtrs_srv_path *srv_path,
|
|||
}
|
||||
if (changed)
|
||||
srv_path->state = new_state;
|
||||
spin_unlock_irq(&srv_path->state_lock);
|
||||
spin_unlock_irqrestore(&srv_path->state_lock, flags);
|
||||
|
||||
return changed;
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue