OrgACRN
/
acrn-kernel
mirror of https://github.com/projectacrn/acrn-kernel.git
1
0
Fork 0
Code Issues Releases Wiki Activity

powerpc/xmon: Fix -Wswitch-unreachable warning in bpt_cmds 

When building with automatic stack variable initialization, GCC 12
complains about variables defined outside of switch case statements.
Move the variable into the case that uses it, which silences the warning:

arch/powerpc/xmon/xmon.c: In function ‘bpt_cmds’:
arch/powerpc/xmon/xmon.c:1529:13: warning: statement will never be executed [-Wswitch-unreachable]
 1529 |         int mode;
      |             ^~~~

Fixes: 09b6c1129f ("powerpc/xmon: Fix compile error with PPC_8xx=y")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/YySE6FHiOcbWWR+9@work
This commit is contained in:
Gustavo A. R. Silva 2022-09-16 15:15:04 +01:00 committed by Michael Ellerman
parent 4ac9d3187c
commit 1c4a4a4c84
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
arch/powerpc/xmon/xmon.c
View File

@ -1525,9 +1525,9 @@ bpt_cmds(void)
cmd = inchar();
switch (cmd) {
static const char badaddr[] = "Only kernel addresses are permitted for breakpoints\n";
int mode;
case 'd': /* bd - hardware data breakpoint */
case 'd': { /* bd - hardware data breakpoint */
static const char badaddr[] = "Only kernel addresses are permitted for breakpoints\n";
int mode;
if (xmon_is_ro) {
printf(xmon_ro_msg);
break;
@ -1560,6 +1560,7 @@ bpt_cmds(void)
force_enable_xmon();
break;
}
case 'i': /* bi - hardware instr breakpoint */
if (xmon_is_ro) {