OrgACRN
/
acrn-kernel
mirror of https://github.com/projectacrn/acrn-kernel.git
1
0
Fork 0
Code Issues Releases Wiki Activity

ata: pata_legacy: fix pdc20230_set_piomode() 

Clang gives a warning when compiling pata_legacy.c with 'make W=1' about
the 'rt' local variable in pdc20230_set_piomode() being set but unused.
Quite obviously, there is an outb() call missing to write back the updated
variable. Moreover, checking the docs by Petr Soucek revealed that bitwise
AND should have been done with a negated timing mask and the master/slave
timing masks were swapped while updating...

Fixes: 669a5db411 ("[libata] Add a bunch of PATA drivers.")
Reported-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
This commit is contained in:
Sergey Shtylyov 2022-10-29 00:07:06 +03:00 committed by Damien Le Moal
parent 2ce3a0bf20
commit 171a93182e
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/ata/pata_legacy.c
View File

@ -315,9 +315,10 @@ static void pdc20230_set_piomode(struct ata_port *ap, struct ata_device *adev)
outb(inb(0x1F4) & 0x07, 0x1F4); outb(inb(0x1F4) & 0x07, 0x1F4);
rt = inb(0x1F3); rt = inb(0x1F3);
rt &= 0x07 << (3 * adev->devno); rt &= ~(0x07 << (3 * !adev->devno));
if (pio) if (pio)
rt |= (1 + 3 * pio) << (3 * adev->devno); rt |= (1 + 3 * pio) << (3 * !adev->devno);
outb(rt, 0x1F3);
udelay(100); udelay(100);
outb(inb(0x1F2) | 0x01, 0x1F2); outb(inb(0x1F2) | 0x01, 0x1F2);