OrgACRN
/
acrn-kernel
mirror of https://github.com/projectacrn/acrn-kernel.git
1
0
Fork 0
Code Issues Releases Wiki Activity

selinux: various sparse fixes 

When running the SELinux code through sparse, there are a handful of
warnings.  This patch resolves some of these warnings caused by
"__rcu" mismatches.

 % make W=1 C=1 security/selinux/

Signed-off-by: Paul Moore <paul@paul-moore.com>
This commit is contained in:
Paul Moore 2022-01-27 10:56:13 -05:00
parent 6bc1968c14
commit 0e326df069
4 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
security/selinux/hooks.c
View File

@ -2553,7 +2553,7 @@ static void selinux_bprm_committed_creds(struct linux_binprm *bprm)
if (rc) { if (rc) {
clear_itimer(); clear_itimer();
spin_lock_irq(&current->sighand->siglock); spin_lock_irq(&unrcu_pointer(current->sighand)->siglock);
if (!fatal_signal_pending(current)) { if (!fatal_signal_pending(current)) {
flush_sigqueue(&current->pending); flush_sigqueue(&current->pending);
flush_sigqueue(&current->signal->shared_pending); flush_sigqueue(&current->signal->shared_pending);
@ -2561,13 +2561,13 @@ static void selinux_bprm_committed_creds(struct linux_binprm *bprm)
sigemptyset(&current->blocked); sigemptyset(&current->blocked);
recalc_sigpending(); recalc_sigpending();
} }
spin_unlock_irq(&current->sighand->siglock); spin_unlock_irq(&unrcu_pointer(current->sighand)->siglock);
} }
/* Wake up the parent if it is waiting so that it can recheck /* Wake up the parent if it is waiting so that it can recheck
* wait permission to the new task SID. */ * wait permission to the new task SID. */
read_lock(&tasklist_lock); read_lock(&tasklist_lock);
__wake_up_parent(current, current->real_parent); __wake_up_parent(current, unrcu_pointer(current->real_parent));
read_unlock(&tasklist_lock); read_unlock(&tasklist_lock);
} }

2
security/selinux/ibpkey.c
View File

@ -104,7 +104,7 @@ static void sel_ib_pkey_insert(struct sel_ib_pkey *pkey)
tail = list_entry( tail = list_entry(
rcu_dereference_protected( rcu_dereference_protected(
sel_ib_pkey_hash[idx].list.prev, list_tail_rcu(&sel_ib_pkey_hash[idx].list),
lockdep_is_held(&sel_ib_pkey_lock)), lockdep_is_held(&sel_ib_pkey_lock)),
struct sel_ib_pkey, list); struct sel_ib_pkey, list);
list_del_rcu(&tail->list); list_del_rcu(&tail->list);

5
security/selinux/netnode.c
View File

@ -164,8 +164,9 @@ static void sel_netnode_insert(struct sel_netnode *node)
if (sel_netnode_hash[idx].size == SEL_NETNODE_HASH_BKT_LIMIT) { if (sel_netnode_hash[idx].size == SEL_NETNODE_HASH_BKT_LIMIT) {
struct sel_netnode *tail; struct sel_netnode *tail;
tail = list_entry( tail = list_entry(
rcu_dereference_protected(sel_netnode_hash[idx].list.prev, rcu_dereference_protected(
lockdep_is_held(&sel_netnode_lock)), list_tail_rcu(&sel_netnode_hash[idx].list),
lockdep_is_held(&sel_netnode_lock)),
struct sel_netnode, list); struct sel_netnode, list);
list_del_rcu(&tail->list); list_del_rcu(&tail->list);
kfree_rcu(tail, rcu); kfree_rcu(tail, rcu);

2
security/selinux/netport.c
View File

@ -113,7 +113,7 @@ static void sel_netport_insert(struct sel_netport *port)
struct sel_netport *tail; struct sel_netport *tail;
tail = list_entry( tail = list_entry(
rcu_dereference_protected( rcu_dereference_protected(
sel_netport_hash[idx].list.prev, list_tail_rcu(&sel_netport_hash[idx].list),
lockdep_is_held(&sel_netport_lock)), lockdep_is_held(&sel_netport_lock)),
struct sel_netport, list); struct sel_netport, list);
list_del_rcu(&tail->list); list_del_rcu(&tail->list);