ipv4: ignore dst hint for multipath routes
[ Upstream commit6ac66cb03a
] Route hints when the nexthop is part of a multipath group causes packets in the same receive batch to be sent to the same nexthop irrespective of the multipath hash of the packet. So, do not extract route hint for packets whose destination is part of a multipath group. A new SKB flag IPSKB_MULTIPATH is introduced for this purpose, set the flag when route is looked up in ip_mkroute_input() and use it in ip_extract_route_hint() to check for the existence of the flag. Fixes:02b2494161
("ipv4: use dst hint for ipv4 list receive") Signed-off-by: Sriram Yagnaraman <sriram.yagnaraman@est.tech> Reviewed-by: Ido Schimmel <idosch@nvidia.com> Reviewed-by: David Ahern <dsahern@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
b7d25ac362
commit
0b2ee66411
|
@ -57,6 +57,7 @@ struct inet_skb_parm {
|
||||||
#define IPSKB_FRAG_PMTU BIT(6)
|
#define IPSKB_FRAG_PMTU BIT(6)
|
||||||
#define IPSKB_L3SLAVE BIT(7)
|
#define IPSKB_L3SLAVE BIT(7)
|
||||||
#define IPSKB_NOPOLICY BIT(8)
|
#define IPSKB_NOPOLICY BIT(8)
|
||||||
|
#define IPSKB_MULTIPATH BIT(9)
|
||||||
|
|
||||||
u16 frag_max_size;
|
u16 frag_max_size;
|
||||||
};
|
};
|
||||||
|
|
|
@ -584,7 +584,8 @@ static void ip_sublist_rcv_finish(struct list_head *head)
|
||||||
static struct sk_buff *ip_extract_route_hint(const struct net *net,
|
static struct sk_buff *ip_extract_route_hint(const struct net *net,
|
||||||
struct sk_buff *skb, int rt_type)
|
struct sk_buff *skb, int rt_type)
|
||||||
{
|
{
|
||||||
if (fib4_has_custom_rules(net) || rt_type == RTN_BROADCAST)
|
if (fib4_has_custom_rules(net) || rt_type == RTN_BROADCAST ||
|
||||||
|
IPCB(skb)->flags & IPSKB_MULTIPATH)
|
||||||
return NULL;
|
return NULL;
|
||||||
|
|
||||||
return skb;
|
return skb;
|
||||||
|
|
|
@ -2146,6 +2146,7 @@ static int ip_mkroute_input(struct sk_buff *skb,
|
||||||
int h = fib_multipath_hash(res->fi->fib_net, NULL, skb, hkeys);
|
int h = fib_multipath_hash(res->fi->fib_net, NULL, skb, hkeys);
|
||||||
|
|
||||||
fib_select_multipath(res, h);
|
fib_select_multipath(res, h);
|
||||||
|
IPCB(skb)->flags |= IPSKB_MULTIPATH;
|
||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue