OrgACRN
/
acrn-hypervisor
mirror of https://github.com/projectacrn/acrn-hypervisor.git
1
0
Fork 0
Code Issues Releases Wiki Activity

HV: shell: fix temp_str out of bounds buffer access 

String buffer temp_str is defined with size TEMP_STR_SIZE(60U) but accessed with MAX_STR_SIZE(256U). Better to limit the access bound to TEMP_STR_SIZE to prevent potential issue.

Tracked-On: #3549
Signed-off-by: Yifan Luo <luoyifan@cmss.chinamobile.com>
This commit is contained in:
Yifan Luo 2019-08-06 15:10:24 +08:00 committed by ACRN System Integration
parent 50e0a932a2
commit f65ba2154f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hypervisor/debug/shell.c
View File

@ -252,7 +252,7 @@ static uint16_t sanitize_vmid(uint16_t vmid)
char temp_str[TEMP_STR_SIZE]; char temp_str[TEMP_STR_SIZE];
if (vmid >= CONFIG_MAX_VM_NUM) { if (vmid >= CONFIG_MAX_VM_NUM) {
snprintf(temp_str, MAX_STR_SIZE, snprintf(temp_str, TEMP_STR_SIZE,
"VM ID given exceeds the MAX_VM_NUM(%u), using 0 instead\r\n", "VM ID given exceeds the MAX_VM_NUM(%u), using 0 instead\r\n",
CONFIG_MAX_VM_NUM); CONFIG_MAX_VM_NUM);
shell_puts(temp_str); shell_puts(temp_str);