From b1e43b44549cbdc934b918d7e16d2be89bfdbf95 Mon Sep 17 00:00:00 2001 From: Yonghua Huang Date: Sat, 12 Oct 2019 14:36:00 +0800 Subject: [PATCH] hv: fix error debug message in hcall_set_callback_vector this patch is to fix error debug message for invalid 'param' case, there is no string variable for '%s' output, which will potenially trigger hypervisor crash as it may access random memroy address and trigger SMAP violation. Tracked-On: #3801 Signed-off-by: Yonghua Huang --- hypervisor/common/hypercall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hypervisor/common/hypercall.c b/hypervisor/common/hypercall.c index e5684c7e8..8022ba9fa 100644 --- a/hypervisor/common/hypercall.c +++ b/hypervisor/common/hypercall.c @@ -1175,7 +1175,7 @@ int32_t hcall_set_callback_vector(const struct acrn_vm *vm, uint64_t param) pr_err("%s: Targeting to service vm", __func__); ret = -EPERM; } else if ((param > NR_MAX_VECTOR) || (param < VECTOR_DYNAMIC_START)) { - pr_err("%s: Invalid passed vector\n"); + pr_err("%s: Invalid passed vector\n", __func__); ret = -EINVAL; } else { set_vhm_notification_vector((uint32_t)param);