Adding tarfile member sanitization to extractall()
This commit is contained in:
parent
6d1e24058f
commit
a4f1a2f185
|
@ -59,7 +59,26 @@ def install(library_name, library_install):
|
|||
assert tar_mode in ['gz', 'bz2', 'xz', 'tar']
|
||||
print(f'extract: {tar_file}')
|
||||
with tarfile.open(tar_file, 'r') as tar:
|
||||
tar.extractall(path=step['to'], members=tar)
|
||||
def is_within_directory(directory, target):
|
||||
|
||||
abs_directory = os.path.abspath(directory)
|
||||
abs_target = os.path.abspath(target)
|
||||
|
||||
prefix = os.path.commonprefix([abs_directory, abs_target])
|
||||
|
||||
return prefix == abs_directory
|
||||
|
||||
def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
|
||||
|
||||
for member in tar.getmembers():
|
||||
member_path = os.path.join(path, member.name)
|
||||
if not is_within_directory(path, member_path):
|
||||
raise Exception("Attempted Path Traversal in Tar File")
|
||||
|
||||
tar.extractall(path, members, numeric_owner=numeric_owner)
|
||||
|
||||
|
||||
safe_extract(tar, path=step["to"], members=tar)
|
||||
print(f'extract: {tar_file} success')
|
||||
elif step_type == 'remove':
|
||||
remove_path = step['path']
|
||||
|
|
Loading…
Reference in New Issue