OrgACRN
/
acrn-hypervisor
mirror of https://github.com/projectacrn/acrn-hypervisor.git
1
0
Fork 0
Code Issues Releases Wiki Activity

tools: acrn-crashlog: fix some compiler warnings 

This patch is to fix some compiler warnings before enabling the flag to make
compiler warning as compiler error.

The warning message is like:
ignoring return value of ‘write’, declared with attribute warn_unused_result.

Tracked-On: #1122
Signed-off-by: CHEN Gang <gang.c.chen@intel.com>
Reviewed-by: Zhi Jin <zhi.jin@intel.com>
Reviewed-by: Liu, Xinwu <xinwu.liu@intel.com>
This commit is contained in:
CHEN Gang 2018-09-20 14:00:22 +08:00 committed by lijinxia
parent 4e17d2076c
commit 726711e27d
1 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tools/acrn-crashlog/usercrash/crash_dump.c
View File

@ -31,7 +31,7 @@ static void loginfo(int fd, const char *fmt, ...)
{ {
char buf[512]; char buf[512];
va_list ap; va_list ap;
size_t len; size_t len, ret;
va_start(ap, fmt); va_start(ap, fmt);
vsnprintf(buf, sizeof(buf), fmt, ap); vsnprintf(buf, sizeof(buf), fmt, ap);
@ -41,7 +41,10 @@ static void loginfo(int fd, const char *fmt, ...)
if (len <= 0) if (len <= 0)
return; return;
write(fd, buf, len); ret = write(fd, buf, len);
if (ret != len) {
LOGE("write in loginfo failed\n");
}
} }
static const char *get_signame(int sig) static const char *get_signame(int sig)
@ -113,6 +116,7 @@ static int get_backtrace(int pid, int fd, int sig, const char *comm)
{ {
char *membkt; char *membkt;
char format[FORMAT_LENGTH]; char format[FORMAT_LENGTH];
size_t len, ret;
loginfo(fd, "\nBackTrace:\n\n"); loginfo(fd, "\nBackTrace:\n\n");
memset(format, 0, sizeof(format)); memset(format, 0, sizeof(format));
@ -130,8 +134,13 @@ static int get_backtrace(int pid, int fd, int sig, const char *comm)
LOGE("get gdb info failed\n"); LOGE("get gdb info failed\n");
return -1; return -1;
} }
write(fd, membkt, strlen(membkt)); len = strlen(membkt);
ret = write(fd, membkt, len);
free(membkt); free(membkt);
if (ret != len) {
LOGE("write file failed\n");
return -1;
}
return 0; return 0;
} }
@ -159,7 +168,11 @@ static int save_proc_info(int pid, int fd, const char *path, const char *name)
LOGE("read file failed\n"); LOGE("read file failed\n");
return -1; return -1;
} }
write(fd, data, size); ret = write(fd, data, size);
if ((unsigned long)ret != size) {
LOGE("write file failed\n");
return -1;
}
free(data); free(data);
return 0; return 0;