From 2d66d39529b2fcfe228f6c830c30d82db8e889e3 Mon Sep 17 00:00:00 2001 From: Li Fei1 Date: Tue, 7 Apr 2020 14:41:43 +0800 Subject: [PATCH] hv: vpci: refine comment for pci_vdev_update_vbar_base Refine why we set the base_gpa to zero for a vBAR. Tracked-On: #3475 Signed-off-by: Li Fei1 --- hypervisor/dm/vpci/vdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hypervisor/dm/vpci/vdev.c b/hypervisor/dm/vpci/vdev.c index 2bee49a20..705b93097 100644 --- a/hypervisor/dm/vpci/vdev.c +++ b/hypervisor/dm/vpci/vdev.c @@ -137,10 +137,9 @@ static void pci_vdev_update_vbar_base(struct pci_vdev *vdev, uint32_t idx) } if ((base != 0UL) && !ept_is_mr_valid(vpci2vm(vdev->vpci), base, vdev->vbars[idx].size)) { - pr_fatal("%s, %x:%x.%x set invalid bar[%d] base: 0x%lx, size: 0x%lx\n", __func__, + pr_warn("%s, %x:%x.%x set invalid bar[%d] base: 0x%lx, size: 0x%lx\n", __func__, vdev->bdf.bits.b, vdev->bdf.bits.d, vdev->bdf.bits.f, idx, base, vdev->vbars[idx].size); - /* If guest set a invalid GPA, ignore it temporarily */ - base = 0UL; + base = 0UL; /* 0UL means invalid GPA, so that EPT won't map */ } vdev->vbars[idx].base_gpa = base;