OrgACRN
/
acrn-hypervisor
mirror of https://github.com/projectacrn/acrn-hypervisor.git
1
0
Fork 0
Code Issues Releases Wiki Activity

hv: pci: fix a minor bug about is_pci_cfg_multifunction 

Before checking whether a PCI device is a Multi-Function Device or not, we need
make sure this PCI device is a valid PCI device. For a valid PCI device, the
'Header Layout' field in Header Type Register must be 000 0000b (Type 0 PCI device)
or 000 0001b (Type 1 PCI device).

So for a valid PCI device, the Header Type can't be 0xff.

Tracked-On: #4134
Signed-off-by: Fei Li <fei1.li@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
This commit is contained in:
Fei Li 2021-09-09 16:40:56 +08:00 committed by wenlingz
parent e68d66341e
commit 0a515ab2ea
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hypervisor/include/hw/pci.h
View File

@ -391,7 +391,7 @@ static inline bool is_pci_vendor_valid(uint32_t vendor_id)
static inline bool is_pci_cfg_multifunction(uint8_t header_type) static inline bool is_pci_cfg_multifunction(uint8_t header_type)
{ {
return ((header_type & PCIM_MFDEV) == PCIM_MFDEV); return ((header_type != 0xffU) && ((header_type & PCIM_MFDEV) == PCIM_MFDEV));
} }
static inline bool pci_is_valid_access_offset(uint32_t offset, uint32_t bytes) static inline bool pci_is_valid_access_offset(uint32_t offset, uint32_t bytes)